[Java] Add null pointer check to add/put methods #5386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit e3d04ee (issue swagger-api#5240) introduced unsafe add/put methods for optional list/map parameters. This change maintains the spirit of issue swagger-api#5240 (optional containers are null by default) while still making add/put calls safe. It does this by checking for null first and, if so, initializing it with an empty container. Also updated the affected samples using the various scripts in bin/.
Contributor
Author
|
Fix for #5385 |
Contributor
|
@bbdouglas thanks for the PR, which looks good to me. |
wing328
changed the title
davidgri
pushed a commit
to davidgri/swagger-codegen
that referenced
this pull request
May 11, 2017
…-api#5386) Commit e3d04ee (issue swagger-api#5240) introduced unsafe add/put methods for optional list/map parameters. This change maintains the spirit of issue swagger-api#5240 (optional containers are null by default) while still making add/put calls safe. It does this by checking for null first and, if so, initializing it with an empty container. Also updated the affected samples using the various scripts in bin/.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit e3d04ee (issue #5240) introduced unsafe add/put methods for optional
list/map parameters. This change maintains the spirit of issue #5240 (optional
containers are null by default) while still making add/put calls safe. It does
this by checking for null first and, if so, initializing it with an empty
container.
Also updated the affected samples using the various scripts in bin/.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
A minor change to #5363 to check for nulls before adding/putting values into optional lists/maps.